lams-github

lams_tool_sbmt

Clone Tools

Stats

Commits this week: 1
Total Committers: 29
Last Commit:
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 29 Sep 2023
1:01 am

Andrey Balan

LDEV-5397 make formActionUrl attribute non required

Options
    • -1
    • +0
    ./web/learner/notebook.jsp
  2. … 6 more files in changeset.
Thursday 28 Sep 2023
7:59 pm

Andrey Balan

LDEV-5397 spread changes to tags across all projects

Options
    • -2
    • +2
    ./web/WEB-INF/tags/NotebookReedit.tag
    • -10
    • +3
    ./web/WEB-INF/tags/Rating5.tag
    • -0
    • +553
    ./web/WEB-INF/tags/StyledRating5.tag
    • -18
    • +27
    ./web/WEB-INF/tags/TSTable5.tag
    • -0
    • +4
    ./web/WEB-INF/tlds/lams/lams.tld
  6. … 150 more files in changeset.
Tuesday 19 Sep 2023
2:53 am

Andrey Balan

LDEV-5397 switch to using updated DefineLater.tag

Options
    • -17
    • +20
    ./web/WEB-INF/tags/DefineLater.tag
    • -0
    • +4
    ./web/WEB-INF/tags/PageLearner.tag
    • -4
    • +1
    ./web/learner/definelater.jsp
  4. … 93 more files in changeset.
12:27 am

Andrey Balan

LDEV-5397 remove <hr> as long as .instructions class already has bottom border

Options
    • -1
    • +0
    ./web/learner/sbmtlearner.jsp
  2. … 1 more file in changeset.
Sunday 17 Sep 2023
3:53 am

Andrey Balan

LDEV-5397 Propagade changes done to LAMS tags to all projects

Options
    • -1
    • +1
    ./web/WEB-INF/tags/Alert5.tag
    • -2
    • +2
    ./web/WEB-INF/tags/FileUpload5.tag
    • -2
    • +2
    ./web/WEB-INF/tags/LeaderDisplay.tag
    • -1
    • +1
    ./web/WEB-INF/tags/Notebook.tag
    • -2
    • +2
    ./web/WEB-INF/tags/Page5.tag
    • -95
    • +96
    ./web/WEB-INF/tags/Rating.tag
    • -0
    • +230
    ./web/WEB-INF/tags/Rating5.tag
    • -1
    • +1
    ./web/WEB-INF/tags/StyledRating.tag
    • -1
    • +1
    ./web/WEB-INF/tags/TSTable5.tag
    • -0
    • +4
    ./web/WEB-INF/tlds/lams/lams.tld
  11. … 310 more files in changeset.
3:49 am

Andrey Balan

LDEV-5397 Migrate old Bootstrap3 class names into Bootstrap5 in *all* tools' learning

* Did this following 2 guides:

https://getbootstrap.com/docs/4.1/migration/

https://getbootstrap.com/docs/5.2/migration/

* Apart from changing class names, also performed other updates required in aforementioned guides.

For instance, checkboxes, radios, selects have now proper Bootstrap5 structure; removed "media" objects.

* Replaced some outdated LAMS class names

Options
    • -2
    • +2
    ./web/learner/sbmtlearner.jsp
  2. … 105 more files in changeset.
Thursday 07 Sep 2023
12:33 am

Andrey Balan

LDEV-5397 propagate tag changes to all tools

Options
    • -1
    • +8
    ./web/WEB-INF/tags/CKEditor.tag
    • -1
    • +1
    ./web/WEB-INF/tags/DefineLater.tag
    • -2
    • +1
    ./web/WEB-INF/tags/Notebook.tag
    • -0
    • +70
    ./web/WEB-INF/tags/NotebookReedit.tag
    • -0
    • +1
    ./web/WEB-INF/tags/PageLearner.tag
    • -4
    • +4
    ./web/WEB-INF/tags/Rating.tag
    • -2
    • +2
    ./web/WEB-INF/tags/WaitForLeader.tag
    • -1
    • +5
    ./web/WEB-INF/tlds/lams/lams.tld
  9. … 351 more files in changeset.
Wednesday 30 Aug 2023
2:17 am

Andrey Balan

LDEV-5397 simplify .lcard related CSS classes

* lcard's header is .lcard-header-lg by default now

* move rules from .lcard-no-borders and .shadow into .lcard class

* remove not used .nextActivity class

Options
    • -4
    • +4
    ./web/learner/sbmtlearner.jsp
  2. … 11 more files in changeset.
Sunday 27 Aug 2023
11:34 am

Ernie Ghiglione

LDEV-4917 Add Italian to Uppy i18n in Submit files

Options
    • -0
    • +4
    ./web/learner/sbmtlearner.jsp
Saturday 26 Aug 2023
8:32 am

Marcin Cieslak

Merge remote-tracking branch 'origin/v4.7' into LDEV-5397

# Conflicts:

# lams_tool_sbmt/web/learner/sbmtlearner.jsp

Options
    • -10
    • +9
    ./web/learner/sbmtlearner.jsp
  2. … 9 more files in changeset.
8:27 am

Marcin Cieslak

LDEV-5397 Boostrap 5 bundle already has got Popper included

Options
    • -13
    • +12
    ./web/WEB-INF/tags/PageLearner.tag
  2. … 33 more files in changeset.
Friday 25 Aug 2023
2:02 am

Andrey Balan

LDEV-5397 add icons to finish and refresh buttons

Options
    • -1
    • +1
    ./web/WEB-INF/tags/SubmissionDeadline.tag
    • -1
    • +1
    ./web/WEB-INF/tags/WaitForLeader.tag
  3. … 64 more files in changeset.
1:48 am

Andrey Balan

LDEV-5397 add icons to finish and refresh buttons

Options
    • -1
    • +1
    ./web/WEB-INF/tags/DefineLater.tag
    • -8
    • +6
    ./web/WEB-INF/tags/Notebook.tag
  3. … 66 more files in changeset.
12:46 am

Andrey Balan

LDEV-5397 make SubmissionDeadline.tag call checkNextGateActivity()

Options
    • -2
    • +4
    ./web/WEB-INF/tags/SubmissionDeadline.tag
  2. … 32 more files in changeset.
Thursday 24 Aug 2023
1:41 am

Andrey Balan

LDEV-5397 introduce submissionDeadline.tag

* switched to using this tag in all tools

* fixed a few existing issues with submissionDeadline feature in Vote and MCQ tools

Options
    • -0
    • +117
    ./web/WEB-INF/tags/SubmissionDeadline.tag
    • -0
    • +4
    ./web/WEB-INF/tlds/lams/lams.tld
    • -46
    • +8
    ./web/learner/submissionDeadline.jsp
  4. … 79 more files in changeset.
Friday 18 Aug 2023
12:28 pm

Ernie Ghiglione

LDEV-5345 Adding and updating latest translations

Options
    • -0
    • +1
    ./conf/language/lams/ApplicationResources_de_DE.properties
    • -1
    • +1
    ./conf/language/lams/ApplicationResources_fr_FR.properties
  3. … 64 more files in changeset.
3:28 am

Andrey Balan

LDEV-5397 spread change to LeaderDisplay.tag to all tools

Options
    • -4
    • +6
    ./web/WEB-INF/tags/LeaderDisplay.tag
  2. … 32 more files in changeset.
3:23 am

Andrey Balan

LDEV 5397 remove href="#nogo" and similar nonexistant same-page link

Due to screenreader requirements we can no longer use links having href="#target" when a page does not have this corresponding target. There are a couple of techniques instead of it:

1. links' onclick event should end with "return false;" ("false" can be replaced with anything else but true)

It applies to onclick events specified as tag attributes as well as added with Javascript or jQuery

2. turn links into <button type="button">

3. <a data-bs-toggle="collapse"> having href="#nogo" are OK. presumably as their onclick events return false;

Options
    • -2
    • +2
    ./web/learner/submissionDeadline.jsp
  2. … 7 more files in changeset.
Tuesday 15 Aug 2023
1:29 am

Andrey Balan

LDEV-5397 Introduce Notebook.tag

Options
    • -2
    • +2
    ./src/java/org/lamsfoundation/lams/tool/sbmt/web/controller/LearningController.java
    • -0
    • +108
    ./web/WEB-INF/tags/Notebook.tag
    • -193
    • +153
    ./web/WEB-INF/tlds/lams/lams.tld
    • -51
    • +9
    ./web/learner/notebook.jsp
  5. … 69 more files in changeset.
Sunday 13 Aug 2023
3:17 am

Andrey Balan

LDEV-5397 center leader alert

Options
    • -1
    • +1
    ./web/WEB-INF/tags/LeaderDisplay.tag
  2. … 32 more files in changeset.
12:36 am

Andrey Balan

LDEV-5397 further bootstrap 5 related changes

Also

* change bootstrap classes from col-*-offset-* to offset-*-

* deprecated form-group

* .hidden-xs to .d-none .d-sm-block

* .pull-left to .float-start

* .pull-right to .float-end

* add class="activity-bottom-buttons"

Options
    • -3
    • +1
    ./web/learner/notebook.jsp
    • -6
    • +4
    ./web/learner/submissionDeadline.jsp
    • -4
    • +4
    ./web/monitoring/mark/fileinfo.jsp
    • -1
    • +1
    ./web/monitoring/mark/filelist.jsp
  5. … 113 more files in changeset.
12:19 am

Andrey Balan

LDEV-5397 copy-tags across LAMS projects

Options
    • -2
    • +2
    ./web/WEB-INF/tags/Alert.tag
    • -6
    • +2
    ./web/WEB-INF/tags/Alert5.tag
  3. … 35 more files in changeset.
12:16 am

Andrey Balan

LDEV-5397 add missing function preventLearnerAutosaveFromMultipleTabs(autosaveInterval)

Options
    • -0
    • +13
    ./web/WEB-INF/tags/PageLearner.tag
  2. … 32 more files in changeset.
12:11 am

Andrey Balan

LDEV-5397 migrate defineLater tag and jsps to bootstrap 5

Options
    • -1
    • +1
    ./src/java/org/lamsfoundation/lams/tool/sbmt/web/controller/LearningController.java
    • -11
    • +12
    ./web/WEB-INF/tags/DefineLater.tag
    • -9
    • +2
    ./web/learner/definelater.jsp
  4. … 40 more files in changeset.
Saturday 12 Aug 2023
10:49 pm

Andrey Balan

LDEV-5397 Introduce WaitForLeader.tag

Options
    • -0
    • +75
    ./web/WEB-INF/tags/WaitForLeader.tag
    • -1
    • +5
    ./web/WEB-INF/tlds/lams/lams.tld
    • -51
    • +2
    ./web/learner/waitforleader.jsp
  4. … 66 more files in changeset.
6:44 pm

Ernie Ghiglione

LDEV-5404 Escaping funny characters that break js in tags

- LAMS Central

- LAMS Monitoring

- LAMS Learner

- Assessment

- Gradebook

- Peer Assessment

- Submit

- Scratchie

Options
    • -0
    • +1
    ./web/WEB-INF/tags/AuthoringButton.tag
    • -0
    • +1
    ./web/WEB-INF/tags/AuthoringRatingAllStyleCriteria.tag
    • -0
    • +1
    ./web/WEB-INF/tags/AuthoringRatingCriteria.tag
    • -0
    • +1
    ./web/WEB-INF/tags/Page.tag
    • -0
    • +1
    ./web/WEB-INF/tags/Page5.tag
  6. … 42 more files in changeset.
5:45 pm

Ernie Ghiglione

LDEV-5404 Escaping funny characters that break js

- Submit files

Note that we have to also do this for tags, something I didn't do before. So that's a pending task for all previously changed tools

Options
    • -1
    • +1
    ./web/WEB-INF/tags/AuthoringButton.tag
    • -30
    • +30
    ./web/WEB-INF/tags/AuthoringRatingAllStyleCriteria.tag
    • -4
    • +4
    ./web/WEB-INF/tags/AuthoringRatingCriteria.tag
    • -3
    • +4
    ./web/WEB-INF/tags/OutcomeAuthor.tag
    • -1
    • +1
    ./web/WEB-INF/tags/Page.tag
    • -1
    • +1
    ./web/WEB-INF/tags/Page5.tag
    • -0
    • +1
    ./web/common/taglibs.jsp
    • -10
    • +8
    ./web/learner/sbmtlearner.jsp
    • -2
    • +2
    ./web/monitoring/mark/allmarks.jsp
    • -2
    • +2
    ./web/monitoring/mark/mark.jsp
    • -3
    • +3
    ./web/monitoring/mark/updatemark.jsp
    • -11
    • +11
    ./web/monitoring/parts/summary.jsp
Tuesday 08 Aug 2023
6:39 am

Marcin Cieslak

Merge remote-tracking branch 'origin/v4.7' into LDEV-5397

# Conflicts:

# lams_build/lams_build.eml

# lams_central/web/css/components.css

# lams_gradebook/lams_gradebook.eml

# lams_monitoring/lams_monitoring.eml

# lams_monitoring/web/monitor.jsp

# lams_tool_laqa/web/learning/AnswersContent.jsp

# lams_tool_sbmt/conf/language/lams/ApplicationResources.properties

# lams_tool_sbmt/conf/language/lams/ApplicationResources_en_AU.properties

# lams_www/web/public/ckeditor-templates/bootsnippets.js

Options
    • -11
    • +11
    ./conf/language/lams/ApplicationResources.properties
    • -11
    • +11
    ./conf/language/lams/ApplicationResources_en_AU.properties
  3. … 7 more files in changeset.
Monday 31 Jul 2023
12:18 pm

Marcin Cieslak

LDEV-5405 Make Popover tag work with Bootstrap both version 3 and 5

Options
    • -7
    • +7
    ./web/WEB-INF/tags/Popover.tag
  2. … 32 more files in changeset.
Friday 28 Jul 2023
2:51 pm

Ernie Ghiglione

LDEV-5345 Adding and updating latest translations

Options
    • -1
    • +3
    ./conf/language/lams/ApplicationResources_de_DE.properties
    • -1
    • +1
    ./conf/language/lams/ApplicationResources_el_GR.properties
    • -1
    • +1
    ./conf/language/lams/ApplicationResources_es_ES.properties
  4. … 123 more files in changeset.